Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository could benefit from being a Python package. #46

Open
gregtkogut opened this issue Jan 25, 2023 · 0 comments
Open

Repository could benefit from being a Python package. #46

gregtkogut opened this issue Jan 25, 2023 · 0 comments

Comments

@gregtkogut
Copy link

gregtkogut commented Jan 25, 2023

This repository could benefit from being a Python package using setup.py or pyproject.toml.

This way when following the directions on the main README, there could be one extra step to install the package, e.g.

pip install -e /location/of/api-samples

Then the samples could be run pretty seamlessly, and modified in-place with key changes, etc. As it is when trying to run the sample net_device_signal_samples.py I had to manually modify the PYTHONPATH so that the internally-defined monitoring.utils.session package could be correctly imported by Python within the virtual environment.

I could supply a PR if this idea seems good. It's not a big deal, would just make quick operation of the samples a little easier and quicker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant