Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location name (city) to database table #7

Open
webdevilopers opened this issue Nov 21, 2014 · 2 comments
Open

Add location name (city) to database table #7

webdevilopers opened this issue Nov 21, 2014 · 2 comments

Comments

@webdevilopers
Copy link

I think the city resp. location name for a postalCode can be very useful.

I can make a PR for this as soon I am available if you like @craue .

@craue
Copy link
Owner

craue commented Nov 22, 2014

The bundle assumes that each postal code is unique for a country and maps to one location (latitude + longitude), which is not exactly the case in the real world. When importing data the same postal code may appear several times for slightly different locations and with different names. So I don't think it's a good idea trying so save the name as well.

@webdevilopers
Copy link
Author

I'm thinking about a location search where you choose your country and then type a postal code or city name.

This could then easily be achieved by using your bundles table which adds a great feature, don't you think?

But i get you point too. So for this use case you recommend overriding the addEntries method for the fixtures and extend your existing GeoPostalCode Entity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants