PTY detection issues.

[lyrixx]

Hello,

Thanks for your hard work! This is really cool.

We are integrating it to castor and be able to ship task runners as standalone lib.

But we face a strange bug with PTY:

With the static binary:

proc_open('echo 1 >/dev/null', [['pty'], ['pty'], ['pty']], $pipes)

Warning: proc_open(): PTY (pseudoterminal) not supported on this system  

Actually, my term DO supports PTY.

>…om/jolicode/castor(add-compile-command *%) php -a
Interactive shell

php > var_dump(proc_open('echo 1 >/dev/null', [['pty'], ['pty'], ['pty']], $pipes));
resource(7) of type (process)

[crazywhalecc]

Thanks for reporting this bug.

I just looked for the source code and found that this line of patch code was added when the event extension was added 10 months ago.

static-php-cli/src/SPC/store/SourcePatcher.php

Line 214 in cac3ffc

FileSystem::replaceFile(SOURCE_PATH . '/php-src/main/php_config.h', REPLACE_FILE_PREG, '/^#define HAVE_OPENPTY 1$/m', '');

This issue is related to event extension support on macOS: it will encounter openpty errors when compiling event extensions on macOS.

After removing this line, openpty just works. I will fix this. Bugs in the Event extension on macOS will be documented.

[crazywhalecc]

Warning: proc_open(): PTY (pseudoterminal) not supported on this system  

The problem with PTY not being supported has been fixed, but I'm not 100% sure that solved your problem. I've merged the code into the main branch, you can test it with spc binary (nightly build) or test it with git clone.