Linking issue with PHP 8.4 and libpq

[dunglas]

Building the static embed SAPI with Postgres causes a linking issue: the Postgres library isn't found: https://github.com/dunglas/frankenphp/actions/runs/11986745297/job/33420123250?pr=1193#step:6:21679

The problem only occurs with PHP 8.4.

[dunglas]

Passing explicitly something ${PWD}/buildroot/lib/libpgcommon.a ${PWD}/buildroot/lib/libpgport.a ${PWD}/buildroot/lib/libpq.a to the linker works as a workaround.

[crazywhalecc]

PHP 8.4 has changed pgsql config.m4: php/php-src@f4ce50d#diff-41d568c7fe3330be65b29eea92eba5dfca3a928100fadd3e7a382140786a9eceL92

[dunglas]

The problem seems to still be there: https://github.com/dunglas/frankenphp/actions/runs/12233575592/job/34120969565?pr=1231

[crazywhalecc]

@dunglas It seems to be caused by a corrupted pg_config (and my first local test I just removed it...). Simply not specifying the directory will bypass pg_config and fix the missing libraries. See #572

It looks good for now, and I think we can add sanity checks to embed ASAP to reduce this kind of problems.

[dunglas]

Thank you!

[dunglas]

It looks like the issue persists 😅 https://github.com/dunglas/frankenphp/actions/runs/12237202736/job/34132460168?pr=1231

[crazywhalecc]

O....kay. That's weird, I use single extension pgsql it's good to print -lpq -lpgport -lpgcommon ..., but with frankenphp's combination, it indeed occurs.

[dunglas]

Event after #567, the problem persists: https://github.com/dunglas/frankenphp/actions/runs/12325289480/job/34404346372?pr=1231

[crazywhalecc]

@dunglas I'm not sure which extension causes this bug, but it's working and no problem with spc-config. Using php-config also needs patching or passing prefix and other additional flags.

[dunglas]

Sorry I probably missed something but what is spc-config? Should we update our build script to use it?

[crazywhalecc]

@dunglas #573 I added spc-config for static-php:

# Before
buildroot/bin/php-config --libs

# Now
bin/spc spc-config $EXTENSIONS --with-libs=$LIBS --libs

There are also sanity checks using spc-config after building embed SAPI. See: https://static-php.dev/en/guide/manual-build.html#embed-usage