Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable arm64 builds for Linux #53

Closed
praveenkumar opened this issue May 22, 2024 · 2 comments
Closed

Enable arm64 builds for Linux #53

praveenkumar opened this issue May 22, 2024 · 2 comments
Assignees

Comments

@praveenkumar
Copy link
Member

We should build and release arm64 bits for linux as well so that user who want to try arm64 crc linux binary should able to use it.

@cfergeau
Copy link
Contributor

cfergeau commented May 27, 2024

I'd make 2 changes to the spec file

  • change
    install -m 0755 -vp %{gobuilddir}/src/%{goipath}/out/linux-amd64/crc-admin-helper %{buildroot}%{_bindir}/
    so that we always copy a native binary to /usr/bin regardless of the arch (ie build it with go build without forcing GOARCH). This way our ppc64/... packages would also work
  • add an arm64 binary to the /usr/share/crc-admin-helper/redistributable/linux directory. It will be useful at release time to provide an official arm64 binary (
    install -d %{buildroot}%{_datadir}/%{name}-redistributable/{linux,macos,windows}
    install -m 0755 -vp %{gobuilddir}/src/%{goipath}/out/linux-amd64/crc-admin-helper %{buildroot}%{_datadir}/%{name}-redistributable/linux/
    install -m 0755 -vp %{gobuilddir}/src/%{goipath}/out/windows-amd64/crc-admin-helper.exe %{buildroot}%{_datadir}/%{name}-redistributable/windows/
    install -m 0755 -vp %{gobuilddir}/src/%{goipath}/out/macos-universal/crc-admin-helper %{buildroot}%{_datadir}/%{name}-redistributable/macos/
    )

@cfergeau
Copy link
Contributor

cfergeau commented Jul 1, 2024

Fixed in #59

@cfergeau cfergeau closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants