Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] Use crc-cloud in CI environment #37

Closed
lmilbaum opened this issue Feb 7, 2023 · 9 comments
Closed

[Spike] Use crc-cloud in CI environment #37

lmilbaum opened this issue Feb 7, 2023 · 9 comments
Assignees

Comments

@lmilbaum
Copy link
Contributor

lmilbaum commented Feb 7, 2023

No description provided.

@lmilbaum lmilbaum converted this from a draft issue Feb 7, 2023
@lmilbaum lmilbaum self-assigned this Feb 7, 2023
@lmilbaum lmilbaum moved this from Todo to In Progress in Project planning: crc-cloud Feb 7, 2023
@tsebastiani
Copy link
Member

If you need a reference https://github.com/redhat-chaos/krkn/blob/main/.github/workflows/build.yml (still using the bash version suitable for your region)

@lmilbaum
Copy link
Contributor Author

lmilbaum commented Feb 9, 2023

I am implementing an ansible playbook which I could use both in dev and in ci. My current challenge is how to distribute the access keys without exposing them in the log files. @adrianriobo any ideas?

@adrianriobo
Copy link
Contributor

Are those credentials shown anywhere on the log of the container execution? They should not be showed there at all

@lmilbaum
Copy link
Contributor Author

lmilbaum commented Feb 9, 2023

Are those credentials shown anywhere on the log of the container execution? They should not be showed there at all

My challenge is with sharing them with the running container

@adrianriobo
Copy link
Contributor

Making use of gh secrets directly avoid the issue on showing the credentials.

Also this approach has been switched to make use of oidc integration see #44 . Using that approach required credentials are exported as ENVs on the runner, and those credentials are set as secrets so even using them along the github action they will not be shown

@github-project-automation github-project-automation bot moved this from In Progress to Done in Project planning: crc-cloud Feb 17, 2023
@adrianriobo adrianriobo reopened this Feb 17, 2023
@adrianriobo adrianriobo moved this from Done to In Progress in Project planning: crc-cloud Feb 17, 2023
@lmilbaum
Copy link
Contributor Author

@adrianriobo What else is needed to move this issue to Done?

@adrianriobo
Copy link
Contributor

I would like to have a green pass on platform-engineering-org/poc#93 which means I would like to conclude and add changes if needed around #45.

Although this is a spike and not a issue or task may the spike can be closed as we now know for sure it works and track these expectations on platform-engineering-org/poc#93 WDYT?

@lmilbaum
Copy link
Contributor Author

@adrianriobo There is a green pass. I would prefer to merge the PR and close this ticket.

@adrianriobo
Copy link
Contributor

yeah I guess as spike we came to a conclusion so I am fine with it 👍

@github-project-automation github-project-automation bot moved this from In Progress to Done in Project planning: crc-cloud Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants