-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spike] Use crc-cloud in CI environment #37
Comments
If you need a reference https://github.com/redhat-chaos/krkn/blob/main/.github/workflows/build.yml (still using the bash version suitable for your region) |
I am implementing an ansible playbook which I could use both in dev and in ci. My current challenge is how to distribute the access keys without exposing them in the log files. @adrianriobo any ideas? |
Are those credentials shown anywhere on the log of the container execution? They should not be showed there at all |
My challenge is with sharing them with the running container |
Making use of gh secrets directly avoid the issue on showing the credentials. Also this approach has been switched to make use of oidc integration see #44 . Using that approach required credentials are exported as ENVs on the runner, and those credentials are set as secrets so even using them along the github action they will not be shown |
@adrianriobo What else is needed to move this issue to Done? |
I would like to have a green pass on platform-engineering-org/poc#93 which means I would like to conclude and add changes if needed around #45. Although this is a |
@adrianriobo There is a green pass. I would prefer to merge the PR and close this ticket. |
yeah I guess as spike we came to a conclusion so I am fine with it 👍 |
No description provided.
The text was updated successfully, but these errors were encountered: