Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Suggested to take care of the states for Actions #39

Open
gbraad opened this issue Feb 10, 2022 · 0 comments
Open

Suggested to take care of the states for Actions #39

gbraad opened this issue Feb 10, 2022 · 0 comments

Comments

@gbraad
Copy link
Collaborator

gbraad commented Feb 10, 2022

If types are introduced it is suggested to fix:

        const isStarting = this.state.CrcStatus === "Starting";

suggested to be

        const isBusy = (this.state.CrcStatus === "Starting") || (this.state.CrcStatus === "Stopping");

https://github.com/code-ready/crc-react-components/blob/2344936f4718fee12d4c65bcb20c6e8f6b9b136c/src/components/Actions.jsx#L31

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant