Switch to session libvirt #35
Conversation
| @@ -496,7 +511,7 @@ func (d *Driver) getMAC() (string, error) { | |||
| } | |||
|
|
|||
| func (d *Driver) getIPByMacFromSettings(mac string) (string, error) { | |||
| conn, err := d.getConn() | |||
| conn, err := d.getSystemConn() | |||
There was a problem hiding this comment.
Does this method needs more changes? It seems to expect a libvirt network, but we switched to bridges? With qemu:///session, can we get the vm ip address without using qemu:///system?
There was a problem hiding this comment.
We switched to using the network in the VM as a bridge, we still know that it's a libvirt network existing on the system connection. So I don't think so.
zeenix
force-pushed
the
session
branch
2 times, most recently
from
0da5269 to
18aa92d
Compare
There was a problem hiding this comment.
With this commit, machine-driver-libvirt only needs qemu:///session for read-only access to the 'crc' network. It uses it to check everything is in order before starting a VM, and to get the bridge name which will be used in getIPByMacFromSettings, and when creating a new VM.
Overall looks good, needs careful testing, and maybe further adjustments on the crc side (for example, create a polkit ACL only allowing read access to the 'crc' network rather than adding the user to the libvirt group).
Correct but I think you meant |
The `crc` network can live on the system libvirt while we do the rest on the session connection. Fixes crc-org#20.
|
We will reopen this PR if needed. #20 is still opened. |
The
crcnetwork can live on the system libvirt while we do the rest on the session connection.This requires crc-org/crc#709.
Fixes #20.