Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace RPC heartbeat by checking if stdin is opened #57

Open
guillaumerose opened this issue Jan 29, 2021 · 0 comments
Open

Replace RPC heartbeat by checking if stdin is opened #57

guillaumerose opened this issue Jan 29, 2021 · 0 comments

Comments

@guillaumerose
Copy link

CRC always issues RPC calls sequentially (each method of machine.Client interface use it's own driver and they don't goroutines). That means we could potentially remove the server and just send json commands on stdin, and read stdout.

There is still one mechanism we need to deal with: the hearbeat. This feature was made in case of a driver a failure. If it hangs, it will kill itself.

We can do the same by checking the status of stdin. Once it is closed, the driver must exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant