Skip to content
This repository was archived by the owner on Apr 25, 2019. It is now read-only.

Use generic identifier for machine type (libvirt) #13

Open
gbraad opened this issue Jan 11, 2019 · 2 comments
Open

Use generic identifier for machine type (libvirt) #13

gbraad opened this issue Jan 11, 2019 · 2 comments

Comments

@gbraad
Copy link
Collaborator

gbraad commented Jan 11, 2019

https://github.com/praveenkumar/osp4/blob/6d7d65f5d8019beab975ad6f1d325aad593a3839/libvirt/minishift_libvirt.sh#L128

Reference #12
@gbraad gbraad changed the title Use generic identifierfor machine type (libvirt) Use generic identifier for machine type (libvirt) Jan 11, 2019
@gbraad gbraad mentioned this issue Jan 11, 2019
Closed
@gbraad
Copy link
Collaborator Author

gbraad commented Jan 11, 2019

We could use pc instead as it defaults to the latest known 'standard PC' definition. WDYT?

@praveenkumar
Copy link
Member

Sure, we should update it. I am thinking to have a bare minimal config so that target platform should create according to what is missing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gbraad @praveenkumar