Improve typed task outputs #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pydantic-or-json-output
…-json-output' of https://github.com/joaomdmoura/crewAI into brandon/cre-492-improve-task-execution-with-pydantic-or-json-output
pythonbyte
approved these changes
Nov 26, 2024
| @@ -214,3 +214,29 @@ def create_converter( | |||
| raise Exception("No output converter found or set.") | |||
|
|
|||
| return converter | |||
|
|
|||
|
|
|||
| def generate_model_description(model: Type[BaseModel]) -> str: | |||
There was a problem hiding this comment.
Nitpick: Adding a docstring here could be good to inform the user about the function's goal
…pydantic-or-json-output
…-json-output' of https://github.com/joaomdmoura/crewAI into brandon/cre-492-improve-task-execution-with-pydantic-or-json-output
bhancockio
deleted the
brandon/cre-492-improve-task-execution-with-pydantic-or-json-output
branch
|
I confirmed that this is working well. I'm looking forward to the next release, which should improve the performance of all agents using Pydantic. Having the prompt a bit larger (more tokens) in my use-case, I'm noticing a few more secs on avg, but that's 👌 from my perspective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.