-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Checking all files when using only_changed
and dry
#61
Comments
only_changed
and dry
`only_changed
and dry
I'm experiencing the same issue with v4.0. @olaven what about you? |
I'm still getting this too.
The output suggests that there are no matching files (as I'd expect; my PR has no js/jsx/less changes):
But then goes on to run all files in the repo anyway and fails. EDIT: This is running the latest version of the action, 4.1.1 |
I am experiencing this exact same problem with v4.2 |
+1 |
I have the same problem with the version 4.3 |
+1, same issue v4.3 |
I am also getting this on v4.3 |
Hi! Thank you for maintaining this action :-)
I'm unfortunaltely experiencing what I believe is unexpected behaviour when using the config below.
What exactly happened?
Fails even though all files in changed in the latest commit are formatted properly.
Steps to reproduce the behavior:
.prettierrc
What should've happened?
I expected the job to pass. Other files in the repository are
not properly formatted, but I expected those to be ignored due to
only_changed: True
.I'm using v3.3.
The text was updated successfully, but these errors were encountered: