Major Update 4.0 #48
Merged
Major Update 4.0 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
creyD
commented
Apr 10, 2021
•
creyD
commented
- Switched to way faster composite action (with a lot of help from @jsoref)
- Allowed unofficial plugins (Thanks to @suda)
- Enhanced docs (Thanks to @infotexture)
- Fixed bug [BUG] Dry run reporting unpretty files when all files match styles #37 (Thanks to @fsz-codeshop) (PENDING BUG RESOLVE)
- Added custom GITHUB TOKEN parameter (Thanks to @hpedrorodrigues)
This script uses bashisms
Composite
Moved the action to composite
The previous system relied on a different shell's magic for handling `*` / `**` nullglob - If set, Bash allows filename patterns which match no files to expand to a null string, rather than themselves. globstar - If set, the pattern ‘**’ used in a filename expansion context will match all files and zero or more directories and subdirectories. If the pattern is followed by a ‘/’, only directories and subdirectories match.
The entrypoint script checks for correctly named Prettier plugins on [lines 44–45](https://github.com/creyD/prettier_action/blob/master/entrypoint.sh#L44-L45), but the description in the config file and README are not consistent. This updates those references to clarify how plugins should be specified.
Allow unofficial plugins
…ects the logic as it will never have changes on dry-run
Add input git push options
…npretty Fixes Issues from PR #46 (37 [BUG] Dry run reporting unpretty files when all files match styles)
Add support to override the default github token
|
@fsz-codeshop Could you please take a look at this? Ever since we patched in the changes this action doesn't work anymore (only on dev currently) |
Small fixes for branch dev
This was
linked to
issues
Sep 7, 2021
infotexture
added a commit
to dita-ot/docs
that referenced
this pull request
Oct 2, 2021
This reverts commit 5c8efab. The pre-release version [4.0](https://github.com/creyD/prettier_action/releases/tag/v4.0) causes checks to fail. The changes in creyD/prettier_action#48 fail to recognize the options available in the latest versions of prettier/plugin-xml: [warn] Ignored unknown option { xmlSelfClosingSpace: false }. [warn] Ignored unknown option { xmlWhitespaceSensitivity: "strict" }. Did you mean htmlWhitespaceSensitivity? See https://github.com/prettier/plugin-xml/blob/main/CHANGELOG.md#110---2021-09-26: Signed-off-by: Roger Sheen <[email protected]>
|
@creyD The 4.0 pre-release version fails to recognize the options available in the latest versions of prettier/plugin-xml: Reverting to v3.3 allows checks to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.