Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregate externals #85

Closed
crherman7 opened this issue Dec 20, 2024 · 0 comments · Fixed by #92
Closed

aggregate externals #85

crherman7 opened this issue Dec 20, 2024 · 0 comments · Fixed by #92
Assignees
Labels
review Pull request is ready for review

Comments

@crherman7
Copy link
Owner

crherman7 commented Dec 20, 2024

Is your feature request related to a problem? Please describe.
Module resolver babel plugin i.e. ts aliases will be treated as external dependencies. We need users right now to add those to the .rechunkrc.json which is not ideal.

Describe the solution you'd like
Automatically aggregate all of these based on tsconfig.json file and traverse imports to match and expand array of those externals. Utilize https://www.npmjs.com/package/load-tsconfig or https://www.npmjs.com/package/get-tsconfig to aggregate tsconfig path aliases.

Describe alternatives you've considered
Leave as is.

@crherman7 crherman7 self-assigned this Dec 20, 2024
@crherman7 crherman7 added the hold issue awaiting further discussion label Dec 20, 2024
@crherman7 crherman7 moved this to Todo in ReChunk Roadmap Dec 20, 2024
@crherman7 crherman7 added ready issue ready to be worked on progress issue is in progress and removed hold issue awaiting further discussion ready issue ready to be worked on labels Dec 31, 2024
@crherman7 crherman7 moved this from Todo to In Progress in ReChunk Roadmap Jan 4, 2025
@crherman7 crherman7 linked a pull request Jan 5, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in ReChunk Roadmap Jan 5, 2025
@crherman7 crherman7 added review Pull request is ready for review and removed progress issue is in progress labels Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Pull request is ready for review
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant