-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mraid v2 #322
Merged
Merged
mraid v2 #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: code format update banner api value type -> array
* mraid/mraid-v2: set ad position version bump 5.0.2 # Conflicts: # CriteoPublisherSdk/Sources/MRAID/CRMRAIDHandler.swift # CriteoPublisherSdk/Sources/Standalone/CRBannerView.m
* mraid/mraid-v2: set ad position set supported features send supported features to mraid bridge version bump 5.0.2 # Conflicts: # CriteoPublisherSdk/Sources/MRAID/CRMRAIDHandler.swift # CriteoPublisherSdk/Sources/Standalone/CRBannerView.m
* mraid/mraid-v2: set ad position set supported features send supported features to mraid bridge js interaction code clean up set screen size on ad loading & orientation change # Conflicts: # CriteoPublisherSdk/Sources/MRAID/CRMRAIDHandler.swift
* main: (21 commits) SKAdNetwork 2.1 updates (#313) updated register call in banner custom event updated api handler tests updated adapter tests code format update adapter tests updated google adapter updated register method: storeId is now required for registration version bump & changelog update code formatting return a new instance of GDPR whenever it is needed. version bump & changelog update updated interstitial tests code formatted updated tests set default value for testing to avoid breaking existing tests updated config tests typo disabled failing tests disabled prefetch on sdk initialisation, set default value to live bidding to true. both values are updated by the remote config refresh action. ... # Conflicts: # CriteoPublisherSdk/CriteoPublisherSdk.xcodeproj/project.pbxproj # CriteoPublisherSdk/Sources/Configuration/CR_Config.m # CriteoPublisherSdk/Sources/MRAID/CRMRAIDHandler.swift # CriteoPublisherSdk/Sources/MRAID/MessageHandlers/MRAIDMessaheHandler.swift # CriteoPublisherSdk/Sources/Public/CRInterstitial.h # CriteoPublisherSdk/Sources/Standalone/CRBannerView.m # CriteoPublisherSdk/Sources/Standalone/CRInterstitial.m # CriteoPublisherSdk/Tests/UnitTests/Network/CR_ApiHandlerTests.m # Podfile.lock
* main: banner tests update updated test plans added separate actions split test suite in 3 plans and run them in different actions privacy configuration (#319) # Conflicts: # CriteoPublisherSdk/CriteoPublisherSdk.xcodeproj/project.pbxproj # CriteoPublisherSdk/Sources/MRAID/MessageHandlers/MRAIDMessaheHandler.swift
removed debug code refactored api field in bid request
leonardlabat
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.