Halved the size of the spinner (back to the size it originally was) #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm hang on .. I think I might have forgotten to fix the width too. |
The width of the spinner I think
|
OK now I'm happy with the commit. |
|
Not sure I agree with this, it is awfully small now and heavily aliased (even if it matches the taskbar icon size). |
|
I'll see if I can make a compromise we are both happy with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Halved the size of the spinner (back to the size it originally was)
It's now about the same size (42 x 42px) as a taskbar icon in Windows 10 (48x48px) which I feel is about the perfect size.
If I knew how I would also add a 1 or 2 second wait before it shows up, because if the compile time is THAT short, why even bother people with a message since it's near instantaneous anyways.
Maybe we should also add it to the initial message - since it is the logo after all.