cleanerr: Clean errors for stable status #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some error messages from the kubernetes API contain formatted pointers. This triggers an infinite loop in provider-kubernetes, as each attempt to reconcile updates the status with a new error message. To avoid this loop, mask pointer references in errors on update. A similar fix exists in provider-aws. Without this change, we can see a lot of reconciles for one object over a short time period: Warning CannotUpdateExternalResource 3m38s (x849 over 8m39s) managed/object.kubernetes.crossplane.io (combined from similar events): This might also block other resources from reconciling. Signed-off-by: Carl Henrik Lunde <[email protected]>
turkenh
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Some error messages from the kubernetes API contain formatted pointers. This
triggers an infinite loop in provider-kubernetes, as each attempt to reconcile
updates the status with a new error message.
To avoid this loop, mask pointer references in errors on update.
A similar fix exists in provider-aws.
Without this change, we can see a lot of reconciles for one object over a short
time period:
Warning CannotUpdateExternalResource 3m38s (x849 over 8m39s) managed/object.kubernetes.crossplane.io (combined from similar events):
This might also block other resources from reconciling.
For consideration: It may be that PR #110 effectively fixes most of the issue covered here. Events produced would still be duplicated, but the reconcile spinning would likely stop.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested