Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanerr: Clean errors for stable status #122

Merged
merged 1 commit into from
Aug 18, 2023
Merged

cleanerr: Clean errors for stable status #122

merged 1 commit into from
Aug 18, 2023

Commits on Jun 27, 2023

  1. cleanerr: Clean errors for stable status 

    Some error messages from the kubernetes API contain formatted pointers. This
triggers an infinite loop in provider-kubernetes, as each attempt to reconcile
updates the status with a new error message.

To avoid this loop, mask pointer references in errors on update.

A similar fix exists in provider-aws.

Without this change, we can see a lot of reconciles for one object over a short
time period:

  Warning  CannotUpdateExternalResource  3m38s (x849 over 8m39s)  managed/object.kubernetes.crossplane.io  (combined from similar events):

This might also block other resources from reconciling.

Signed-off-by: Carl Henrik Lunde <[email protected]>
    @chlunde
    chlunde committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    24a587a View commit details
    Browse the repository at this point in the history