Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of Cancel and Save buttons #11

Closed
jherkel opened this issue Dec 4, 2018 · 5 comments
Closed

Translation of Cancel and Save buttons #11

jherkel opened this issue Dec 4, 2018 · 5 comments

Comments

@jherkel
Copy link

jherkel commented Dec 4, 2018

Could you merge this pull request (if it is possible)?
brianpkelley#109
@hayzey
Copy link

hayzey commented Dec 4, 2018 •
edited
Loading

@jherkel Could you make a pull request with the changes you want? There seems to be a lot of code in that PR that is unrelated to those text bindings. If you could make a PR with only the code related to the okText and cancelText bindings, I'd be happy to merge it 😄

@hayzey
Copy link

hayzey commented Dec 11, 2018

@jherkel I've merged your PR and made a new release - version 1.1.0.

@hayzey hayzey closed this as completed Dec 11, 2018
@hayzey hayzey mentioned this issue Dec 11, 2018
Open
@jherkel
Copy link
Author

jherkel commented Dec 11, 2018

I have tried to use a new version 1.1.0 but there is a problem because dist directory still contains old version.Could you also sync dist directory?

@hayzey
Copy link

hayzey commented Dec 11, 2018

@jherkel Oops, my bad. I'll fix that up right away. Thanks for letting me know.

@hayzey
Copy link

hayzey commented Dec 11, 2018

@jherkel I rebuilt dist/ and released a new version - 1.1.1

Let me know if there are any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jherkel @hayzey