Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy macros from sdk_config.h #99

Open
mrquincle opened this issue Feb 10, 2021 · 0 comments
Open

Remove legacy macros from sdk_config.h #99

mrquincle opened this issue Feb 10, 2021 · 0 comments
Labels
clean up Legacy code, unused code, outdated info

Comments

@mrquincle
Copy link

Remove all older NRF macros in the sdk_config.h file. As described at https://devzone.nordicsemi.com/f/nordic-q-a/60127/compare-sdk_config-files there are issues caused by the existence of the older macros. As soon as such a macro exists the file apply_old_config.h will undef all corresponding NRFX macros.

The problem is that sdk_config.h actually defines those macros even if you don't do this yourself in sdk_config.h or app_config.h. So you will see statements like:

#ifndef TIMER_ENABLED
#define TIMER_ENABLED 0
#endif

Suddenly an old macro is defined and next the corresponding NRFX macros will be undefined by apply_old_config.h. Hence, remove all legacy macro ifndef define endif statements in sdk_config.h to fix this.

@mrquincle mrquincle added the clean up Legacy code, unused code, outdated info label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Legacy code, unused code, outdated info
Projects
None yet
Development

No branches or pull requests

1 participant