Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: support helmfile/vals as a plugin in container #611

Open
LPLabrys99 opened this issue Nov 1, 2024 · 3 comments
Open

feature request: support helmfile/vals as a plugin in container #611

LPLabrys99 opened this issue Nov 1, 2024 · 3 comments

Comments

@LPLabrys99
Copy link

Hi, I've been using the argocd lovely plugin for a little while now and I think it's really great.
There is one thing that I think could be better - it would be nice if the container supported the helmfile/vals project by default.
https://github.com/helmfile/vals

Vals is a secrets connector that supports various backends out of the box. As a kubernetes operator you can specify references to secrets in your values files with a format like ref+gcp://.... and vals will look up the secret when templating the charts. It comes built into helmfile but can also be run as a standalone app. Helmfile comes with vals built-in to its own binary but there doesn't seem to be a way to invoke vals through helmfile. If you want to use vals by itself you have to install it as a standalone app.

As a user of argocd/lovely plugin, if I am deploying a single simple Helm chart with some secrets and don't want to set up another helmfile in the repo it would be ideal to use argocd + lovely plugin with standard helm + vals in the pipeline.

@Joibel
Copy link
Contributor

Joibel commented Nov 1, 2024

It looks like this would be achievable with a lovely variation

Would you like to contribute a PR for this?

@LPLabrys99
Copy link
Author

I don't have experience in golang but I'm willing to try.

By the way, given that lovely supports pipeline customisation, is there a reason why vals shouldn't be included in all variations as helmfile is currently?

@Joibel
Copy link
Contributor

Joibel commented Nov 25, 2024

Adding vals: The same argument could be applied to any extra tool that manipulates text.

Vals is not a core feature of lovely. Variations were created specifically for people who want extra tools without adding further possibly security issues to the core of lovely by putting all the tools in the core docker image.

Adding a variation mostly involves writing a Dockerfile, not golang, so perhaps you can tackle it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants