Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop-in replacement support for the binary packages #228

Open
lukewwww opened this issue May 24, 2024 · 1 comment
Open

Drop-in replacement support for the binary packages #228

lukewwww opened this issue May 24, 2024 · 1 comment
Labels
enhancement New feature or request v2.1.0

Comments

@lukewwww
Copy link
Member

No description provided.

@lukewwww lukewwww converted this from a draft issue May 24, 2024
@lukewwww lukewwww added the enhancement New feature or request label May 24, 2024
@lukewwww lukewwww changed the title Drop-in upgrade & auto upgrade for the Windows version Drop-in replacement & auto upgrade for the Windows version Jun 7, 2024
@lukewwww lukewwww changed the title Drop-in replacement & auto upgrade for the Windows version Drop-in replacement support for the binary packages Jun 7, 2024
@lukewwww
Copy link
Member Author

lukewwww commented Jun 7, 2024

I think moving the private key to a separate file that doesn't exist in our released package will be enough.

It is better to give the private key file as much protection as possible.

  1. To encrypt it with a passphrase provided by the user will be too much trouble, the user will have to enter the passphrase every time starting the node. It might be OK for the users who start the node manually on their local devices, it will not be possible to start the node automatically on system start.
  2. Encrypt the private key file with a fixed private key written into a binary, every time the node starts, decrypt the private key using the binary. It is still possible to extract the private key from the binary, but it will not be worth it given that there are not much funds in the wallet under the hot/cold wallet architecture.
  3. Or maybe we should provide both options

@lukewwww lukewwww moved this from Todo to Developing in Helium Network Jun 7, 2024
@lukewwww lukewwww added the v2.1.0 label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.1.0
Projects
Status: Developing
Development

No branches or pull requests

1 participant