Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oauth): make OAuth2 Proxy config map mutable #1038

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Feb 1, 2025

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #984

Description of the change:

  • Removes Immutable property from OAuth2 Proxy config map
  • Deletes and recreates existing config maps with Immutable: true
  • Adds test cases for the config map
  • Fixes an issue where passHostHeader and proxyWebSockets were not in the generated JSON

Motivation for the change:

  • Allows users to disable cert-manager on an existing Cryostat instance

How to manually test:

  1. On Kubernetes, make deploy_bundle BUNDLE_IMG=quay.io/cryostat/cryostat-operator-bundle:3.0.1
  2. make create_cryostat_cr
  3. Build a bundle image for this PR
  4. ./bin/operator-sdk run bundle-upgrade --timeout 5m
  5. Check that Immutable property is no longer present in config map
  6. Edit CR to disable cert-manager, it should redeploy Cryostat properly

@ebaron ebaron added the fix label Feb 1, 2025
@ebaron ebaron requested a review from a team February 1, 2025 01:34
@mergify mergify bot added the safe-to-test label Feb 1, 2025
@ebaron
Copy link
Member Author

ebaron commented Feb 1, 2025

/build_test

Copy link

github-actions bot commented Feb 1, 2025

/build_test completed successfully ✅.
View Actions Run.

@ebaron ebaron merged commit 2735e02 into cryostatio:main Feb 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] TLS is not properly disabled if cert-manager integration is patched off
2 participants