You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since 3cef10f got committed, the bot requests the deposit address of a coin before comparing the coin's order books. This creates an additional HTTP request and this slows down the bot to some degree.
We can probably cache the information whether a coin needs a tag to deposit/withdraw. We could retrieve this information at startup or during some management phase. This information could even be stored in the database.
I don't know whether each coin+exchange combination needs this "requires a tag" flag, or whether this is something coin specific (if exchange A needs it, then assume all exchanges need it)?
FYI: Move the tag check in checkAndTrade() to just below if ( $targetBid->getPrice() <= $sourceAsk->getPrice() ) for an quick optimisation. Comparing both prices is easy and fast, so do that before we do a costly getDepositAddress() call.
The text was updated successfully, but these errors were encountered:
Since 3cef10f got committed, the bot requests the deposit address of a coin before comparing the coin's order books. This creates an additional HTTP request and this slows down the bot to some degree.
We can probably cache the information whether a coin needs a tag to deposit/withdraw. We could retrieve this information at startup or during some management phase. This information could even be stored in the database.
I don't know whether each coin+exchange combination needs this "requires a tag" flag, or whether this is something coin specific (if exchange A needs it, then assume all exchanges need it)?
FYI: Move the tag check in
checkAndTrade()
to just belowif ( $targetBid->getPrice() <= $sourceAsk->getPrice() )
for an quick optimisation. Comparing both prices is easy and fast, so do that before we do a costlygetDepositAddress()
call.The text was updated successfully, but these errors were encountered: