Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix todo about weak keypair generator #2

Open
kmindi opened this issue Aug 20, 2018 · 2 comments
Open

fix todo about weak keypair generator #2

kmindi opened this issue Aug 20, 2018 · 2 comments

Comments

@kmindi
Copy link
Contributor

kmindi commented Aug 20, 2018

// TODO: eine schwäche von krypto es muss ein besserer keypair generator her

@Hirzelts
Copy link
Collaborator

Hirzelts commented Sep 9, 2018

I do not think that there is really an alternative. crypto has no pem-format-keypair generator. Besides, the keypair plugin im using here, is just a wrapper around forges (forge is the other lib) rsa-keypair generator. So it should be fine? It is a discussionworthy problem for the cryptoexamples, that crypto cant generate keypairs.

@kmindi
Copy link
Contributor Author

kmindi commented Sep 10, 2018

Is it (the keypair generator) currently not secure or only inconvinient?
translate the todo and make it understandable what the problem is (still in one line pls)

Does the plugin you use require another crypto library, your comment suggest that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants