From 0bb157e88364acfe78e4b17845f4e6f6c428eb01 Mon Sep 17 00:00:00 2001
From: Nathan Hourt <nathan@followmyvote.com>
Date: Wed, 25 May 2016 14:35:56 -0500
Subject: [PATCH] Resolve #649: [HF] Check authorities on custom_operation

The required_auths field on custom_operation was being ignored during authority checking. This commit causes it to be checked correctly, and adds a unit test verifying as much.
---
 .../graphene/chain/protocol/custom.hpp        |  3 +++
 tests/tests/authority_tests.cpp               | 23 +++++++++++++++++++
 2 files changed, 26 insertions(+)

diff --git a/libraries/chain/include/graphene/chain/protocol/custom.hpp b/libraries/chain/include/graphene/chain/protocol/custom.hpp
index e5701a4b2a..d7a549984d 100644
--- a/libraries/chain/include/graphene/chain/protocol/custom.hpp
+++ b/libraries/chain/include/graphene/chain/protocol/custom.hpp
@@ -50,6 +50,9 @@ namespace graphene { namespace chain {
       account_id_type   fee_payer()const { return payer; }
       void              validate()const;
       share_type        calculate_fee(const fee_parameters_type& k)const;
+      void              get_required_active_authorities( flat_set<account_id_type>& auths )const {
+         auths.insert(required_auths.begin(), required_auths.end());
+      }
    };
 
 } } // namespace graphene::chain
diff --git a/tests/tests/authority_tests.cpp b/tests/tests/authority_tests.cpp
index c46e698fe2..0c13a7ddc9 100644
--- a/tests/tests/authority_tests.cpp
+++ b/tests/tests/authority_tests.cpp
@@ -1313,4 +1313,27 @@ BOOST_FIXTURE_TEST_CASE( nonminimal_sig_test, database_fixture )
    }
 }
 
+BOOST_AUTO_TEST_CASE( custom_operation_required_auths ) {
+   try {
+      ACTORS((alice)(bob));
+      fund(alice);
+      enable_fees();
+
+      signed_transaction trx;
+      custom_operation op;
+      op.payer = alice_id;
+      op.required_auths.insert(bob_id);
+      op.fee = op.calculate_fee(db.current_fee_schedule().get<custom_operation>());
+      trx.operations.emplace_back(op);
+      trx.set_expiration(db.head_block_time() + 30);
+      sign(trx, alice_private_key);
+      GRAPHENE_REQUIRE_THROW(db.push_transaction(trx), tx_missing_active_auth);
+      sign(trx, bob_private_key);
+      PUSH_TX(db, trx);
+   } catch (fc::exception& e) {
+      edump((e.to_detail_string()));
+      throw;
+   }
+}
+
 BOOST_AUTO_TEST_SUITE_END()