Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No output generated #2

Open
jtadmor opened this issue Apr 12, 2016 · 8 comments
Open

No output generated #2

jtadmor opened this issue Apr 12, 2016 · 8 comments
Assignees
Labels

Comments

@jtadmor
Copy link

jtadmor commented Apr 12, 2016

Hi,

This tool looks awesome, but I can't get it to work.

I'm using it by:

import Perf from 'react-addons-perf'
window.Perf = Perf

I start, make some changes, stop. All I see is:

screen shot 2016-04-12 at 4 53 20 pm

I am using this with react 15.0.1, Chrome 49.0.2623 if that helps.

@crysislinux
Copy link
Owner

seems not compatible with v15 now.
the extension uses a different version of react-addons-perf
I am trying to fix it.

@crysislinux crysislinux self-assigned this Apr 13, 2016
@crysislinux
Copy link
Owner

It should work now.

Notice: printDOM is deprecated in React v15, and printOperations is suggested.

It still called dom in the extension, but it is operations in fact if React v15 is used.

Let me know if you meet problems :)

@jtadmor
Copy link
Author

jtadmor commented Apr 13, 2016

I'm still seeing the same. Tried uninstalling and reinstalling the plugin and hard refresh browser, no luck.

@crysislinux
Copy link
Owner

I cannot reproduce the problem. Could you send me a minimal sample of your code?

I tested with:

  • react 15.0.1
  • react-addons-perf 15.0.1
  • Chrome 49.0.2623
  • chrome-react-perf 1.10

image

One more thing. At least one component should rerender during the recording.

Please try to manually type Perf.start() Perf.stop() and Perf.printOperations in the console.

The extension should show the same thing as the console.

@jtadmor
Copy link
Author

jtadmor commented Apr 13, 2016

This is manually doing it in the console:

screen shot 2016-04-13 at 5 54 09 pm

Clicking the same buttons while recording does not produce any output.

What code would you be wanting to see?

(Edit to add: Not trying to be a pain, dont feel the need to reply or anything, I may look through the code this weekend myself).

@andyg303
Copy link

Just to chip in with my experience, 15.0.0 didn't work for me. If I go back to 0.14.8 or forward to 15.0.1 the print outs started working again.

Thanks!

@FionaWong
Copy link

I meet the same question now, sometimes it works as the Landlord printed, sometimes it returns like

2016-11-21 2 33 52

but still no wasted print, I can not believe there is no wasted in the application.

[email protected]
[email protected]
React Perf 1.1.0
chrome 54.0.2840.98 (64-bit)

thanks.

@react-state
Copy link

Hello, I have faced same issue - no wasted output. But this is the same from console and from extension.
react

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants