Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ml-kem CI job to use the right revision for hax-lib #1279

Open
maximebuyse opened this issue Jan 30, 2025 · 0 comments
Open

Improve ml-kem CI job to use the right revision for hax-lib #1279

maximebuyse opened this issue Jan 30, 2025 · 0 comments
Labels

Comments

@maximebuyse
Copy link
Contributor

The ml-kem lax-checking CI job should be using the same hax commit for extraction and hax-lib. For now it uses the hax commit it is ran against for extraction, but it uses main for hax-lib (because libcrux's Cargo.toml points to hax main). For PRs that make changes to hax-lib we need to run this job using hax-lib from the commit being tested.

The current situation is quite annoying in situations like: #1199 (comment)

@maximebuyse maximebuyse added the ci label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant