Add Lint/UnusedComparison and Lint/UnusedLiteral
#507
+830
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one ❤️ I'd rename the rule to |
|
I'll do the code review once you mark the PR as ready for review, just FYI. |
nobodywasishere
changed the title
Lint/UselessComparisonLint/UnusedComparison and Lint/UnusedLiteral
Yeah that's why I marked it as draft, so you wouldn't waste time reviewing it only for me to completely change it. |
nobodywasishere
commented
Nov 23, 2024
|
Running these rules over the ameba, Kagi, and crystal compiler codebases, didn't turn up any violations. Don't know if that's due to a bug in the rules or violations being rare, though I'm leaning towards the latter. |
|
The only literal that isn't supported is |
Need to write more specs to ensure functionality, but from initial testing this works really well
Working implementation of Lint/UnusedLiteral Moved ImplicitReturnVisitor to its own class and expanded it
nobodywasishere
force-pushed
the
nobody/useless-comparison
branch
from
d7ff0fe
to
385ce89
Compare
|
Adding location to RegexLiteral in crystal-lang/crystal#15235 |
Sija
requested changes
Nov 30, 2024
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Sija
requested changes
Dec 2, 2024
Sija
reviewed
Dec 2, 2024
Sija
reviewed
Dec 2, 2024
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #235
Closes #508
This is still a little WIP, I need to go through the code again and write more / better specs. Maybe the visitor can be moved to the main visitors, as it may be useful for writing other
Lint/Useless*rules. It's basically useful for checking if the return value from a node will be captured or not, which is how I determined whether the comparison operations were useful.