Add lint on type and other improvements #145

nobodywasishere · 2024-11-17T10:50:55Z

Closes #89.

Adds a config option lint-trigger that defaults to type, but will be set to save for versions of ameba < 1.6.3
Adds a config option lint-scope that tells the extension how to treat the linter
- file is the current behavior of only running the linter on open files, and removing lints when files are closed
- workspace runs lints for the entire workspace, and doesn't remove them when the file is closed; I personally prefer this mode as it allows me to see lints for files I haven't touched
Moves to using spawn instead of exec as it's required to be able to write to stdin
Adds an output channel to know what the extension is doing, to help with debugging and to make sure it behaves
Disables certain rules by default when typing as they're going to show up (it gets annoying)
I was running into a lot of issues with tasks just not clearing from the queue, so I replaced TaskToken/CancelCallback with the built-in vscode CancellationToken, which worked a lot better
This does add a dependency on semver, which may or may not be desired; if it's not, its functionality can be rewritten locally
Modifying the .ameba.yml will clear all diagnostics from all documents and re-run ameba on them to refresh their diagnostics with the new rules

nobodywasishere · 2024-11-17T16:53:00Z

Apologies for how big this PR is. If you'd prefer it split up, I can do that.

veelenga · 2024-11-17T19:11:54Z

It is not that big. Could you please rebase it, I will continue review/test tomorrow? Thanks for the PR 💪🏻

Switched from exec to spawn to use stdin, and we don't have to worry about paths with spaces

Replaced TaskToken/CancelCallback with vscode CancellationToken due to running into queue issues Added output channel to see what the extension is doing to help w/ debugging onType is enabled by default for ameba >=1.6.3

saving a `.ameba.yml` in a workspace will clear all diagnostics from all documents and re-run ameba on them The latter allows for a very fluid experience of editing the config and seeing the errors in real time

package.json

src/ameba.ts

src/configuration.ts

src/extension.ts

package.json

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

src/configuration.ts

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

src/ameba.ts

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

src/ameba.ts

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

package.json

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

src/ameba.ts

src/configuration.ts

src/extension.ts

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

src/configuration.ts

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

src/taskQueue.ts

src/ameba.ts

src/extension.ts

package.json

…pe config option lint-scope of file is how the ext currently behaves, clearing diagnostics if a file is closed and only linting open files lint-scope of workspace runs ameba over the entire workspace, not clearing them when a file is closed

Sija

It's GTG from me, once the several remaining points are addressed.

nobodywasishere · 2024-11-18T16:59:58Z

It's GTG from me, once the several remaining points are addressed.

I've actually made a few changes locally that will need review as well, primarily around onSave/onType config. I should be able to push in a few hours.

src/configuration.ts

nobodywasishere · 2024-11-18T20:55:26Z

Updated with most recent changes, also updated the description

… workspace

Sija · 2024-11-22T21:46:43Z

@nobodywasishere This PR got pretty big with the recent changes. It would be much easier to review it in parts, would it be possible for you to split it to smaller PRs in order to help with the process?

nobodywasishere added 5 commits November 17, 2024 14:48

WIP run ameba lints on typing

3743b89

Switched from exec to spawn to use stdin, and we don't have to worry about paths with spaces

Working onType plus stability improvements

878d382

Replaced TaskToken/CancelCallback with vscode CancellationToken due to running into queue issues Added output channel to see what the extension is doing to help w/ debugging onType is enabled by default for ameba >=1.6.3

Downgrade engine and @types/vscode, update version

b512e03

Add log about using local ameba

c6a137b

spawn uses workspace cwd (needed to find config)

5a2e88e

saving a `.ameba.yml` in a workspace will clear all diagnostics from all documents and re-run ameba on them The latter allows for a very fluid experience of editing the config and seeing the errors in real time

nobodywasishere force-pushed the nobody/lint-on-type branch from b7521e2 to 5a2e88e Compare November 17, 2024 20:11

Sija requested changes Nov 17, 2024

View reviewed changes

nobodywasishere and others added 3 commits November 17, 2024 18:19

Update src/ameba.ts

05ac5df

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Update src/extension.ts

acf474d

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Update package.json

a1c9152

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Sija reviewed Nov 17, 2024

View reviewed changes

src/configuration.ts Outdated Show resolved Hide resolved

Update src/configuration.ts

29dd198

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Sija reviewed Nov 17, 2024

View reviewed changes

src/ameba.ts Outdated Show resolved Hide resolved

Update src/ameba.ts

bb7e259

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Sija reviewed Nov 17, 2024

View reviewed changes

src/ameba.ts Outdated Show resolved Hide resolved

Sija reviewed Nov 17, 2024

View reviewed changes

src/ameba.ts Outdated Show resolved Hide resolved

nobodywasishere and others added 3 commits November 17, 2024 18:43

Update src/ameba.ts

12478be

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Update src/ameba.ts

6851ed8

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Add onSave to config, reset version in package.json

aa68078

Sija reviewed Nov 17, 2024

View reviewed changes

package.json Show resolved Hide resolved

Sija reviewed Nov 17, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

nobodywasishere and others added 2 commits November 17, 2024 18:52

Update package.json

fef4b58

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Bump minimum vscode to 1.75.0

0a0c358

Sija reviewed Nov 18, 2024

View reviewed changes

src/ameba.ts Outdated Show resolved Hide resolved

Sija reviewed Nov 18, 2024

View reviewed changes

src/configuration.ts Outdated Show resolved Hide resolved

Sija reviewed Nov 18, 2024

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

Sija reviewed Nov 18, 2024

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

Update ameba.ts

a63cb14

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Sija reviewed Nov 18, 2024

View reviewed changes

src/configuration.ts Outdated Show resolved Hide resolved

nobodywasishere and others added 2 commits November 17, 2024 19:17

Update configuration.ts

afaad49

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Update extension.ts

d9d4b7b

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

nobodywasishere commented Nov 18, 2024

View reviewed changes

src/taskQueue.ts Outdated Show resolved Hide resolved

Sija reviewed Nov 18, 2024

View reviewed changes

src/ameba.ts Show resolved Hide resolved

Sija reviewed Nov 18, 2024

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

veelenga reviewed Nov 18, 2024

View reviewed changes

package.json Show resolved Hide resolved

nobodywasishere added 4 commits November 18, 2024 08:46

Fix imports, add support for onSave config, support untitled files

1c2550b

Add command for linting entire workspace

13cff9b

Fix diagnostic uri

103e356

Sija requested changes Nov 18, 2024

View reviewed changes

Sija reviewed Nov 18, 2024

View reviewed changes

src/configuration.ts Outdated Show resolved Hide resolved

Don't do /dev/null shenanigans

9cc93c4

Clear documents when using workspace lint scope if they're not in the…

e283c46

… workspace

nobodywasishere closed this Nov 24, 2024

This was referenced Nov 24, 2024

Move to CancellationToken, Use spawn instead of exec, Add output channel for logging #147

Merged

Add lint on type #148

Closed

Add lint scope setting #149

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add lint on type and other improvements #145

Add lint on type and other improvements #145

nobodywasishere commented Nov 17, 2024 •

edited

Loading

nobodywasishere commented Nov 17, 2024

veelenga commented Nov 17, 2024 •

edited

Loading

Sija left a comment

nobodywasishere commented Nov 18, 2024

nobodywasishere commented Nov 18, 2024

Sija commented Nov 22, 2024

Add lint on type and other improvements #145

Add lint on type and other improvements #145

Conversation

nobodywasishere commented Nov 17, 2024 • edited Loading

nobodywasishere commented Nov 17, 2024

veelenga commented Nov 17, 2024 • edited Loading

Sija left a comment

Choose a reason for hiding this comment

nobodywasishere commented Nov 18, 2024

nobodywasishere commented Nov 18, 2024

Sija commented Nov 22, 2024

nobodywasishere commented Nov 17, 2024 •

edited

Loading

veelenga commented Nov 17, 2024 •

edited

Loading