Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crystal tool format tests #55

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

straight-shoota
Copy link
Member

No description provided.

@straight-shoota straight-shoota added the enhancement New feature or request label Apr 10, 2024
@straight-shoota straight-shoota self-assigned this Apr 10, 2024
@ysbaddaden
Copy link

ysbaddaden commented Jun 10, 2024

I'm not sure all projects use the formatter. I mean that mine usually don't use it, so just checking for the return type may not be enough. For example ysbaddaden/minitest may only pass the formatter check by sheer luck 😅

@straight-shoota
Copy link
Member Author

crystal_format is an explicit test, so we can easily drop it on any project which doesn't maintain the format. We can do that as we notice breakages.

@straight-shoota
Copy link
Member Author

straight-shoota commented Nov 13, 2024

With the formatter changes in the current nightly compiler I realized that formatter tests should not be mixed with functional tests. So I've extracted them into independent test cases which we can filter by tag. Now there's a separate workflow job that tests the formatter exclusively, while all other jobs ignore the formatter checks.

Formatter tests are currently failing, but that's expected because not all shards have adopted the formatter changes in nightly. We should hopefully see a green spec when testing against 1.14, but we can only do that once this PR is merged (automatic builds go against nightly, we can trigger a workflow_dispatch against other builds manually).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants