-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crystal tool format
tests
#55
base: master
Are you sure you want to change the base?
Conversation
I'm not sure all projects use the formatter. I mean that mine usually don't use it, so just checking for the return type may not be enough. For example |
|
3a5d613
to
d58755d
Compare
With the formatter changes in the current nightly compiler I realized that formatter tests should not be mixed with functional tests. So I've extracted them into independent test cases which we can filter by tag. Now there's a separate workflow job that tests the formatter exclusively, while all other jobs ignore the formatter checks. Formatter tests are currently failing, but that's expected because not all shards have adopted the formatter changes in nightly. We should hopefully see a green spec when testing against 1.14, but we can only do that once this PR is merged (automatic builds go against nightly, we can trigger a workflow_dispatch against other builds manually). |
No description provided.