Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode extension to support new nesting syntax #1007

Closed
2 of 3 tasks
equinusocio opened this issue Jun 21, 2023 · 10 comments
Closed
2 of 3 tasks

Update vscode extension to support new nesting syntax #1007

equinusocio opened this issue Jun 21, 2023 · 10 comments
Labels
feature request New feature or request

Comments

@equinusocio
Copy link

equinusocio commented Jun 21, 2023

What would you want to propose?

Currently the vscode extension doesn't support the new nesting syntax which make @nest obsolete.

Before with @nest:

CleanShot 2023-06-21 at 11 48 35

Now:

CleanShot 2023-06-21 at 11 47 27

Suggested solution

nested code is highlighted correctly without @nest

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Would you like to open a PR for this feature?

  • I'm willing to open a PR
@equinusocio equinusocio added the feature request New feature or request label Jun 21, 2023
@romainmenke
Copy link
Member

Hi @equinusocio,

Thank you for reaching out.

Which VSCode extension?


Did you also try the native CSS support in VSCode, we contributed improved support for standard CSS nesting there and it landed in the latest release of VSCode.

@equinusocio
Copy link
Author

equinusocio commented Jun 21, 2023

https://marketplace.visualstudio.com/items?itemName=csstools.postcss

Assuming this is coming from this team since it says csstools as the author.

Did you also try the native CSS support in VSCode, we contributed improved support for standard CSS nesting there and it landed in the latest release of VSCode.

Nope, not yet. But I'll give it a try

@equinusocio
Copy link
Author

sorry, pasted the wrong link:
https://marketplace.visualstudio.com/items?itemName=csstools.postcss

@romainmenke
Copy link
Member

I've never personally contributed to that package/repo and it doesn't seem maintained anymore :/

I've been focussing my efforts on making sure that VSCode itself has really good support for CSS as that helps more people :)

The main difference at this point is likely support for @custom-selector and @custom-media.

@equinusocio
Copy link
Author

By reading the extension reviews, there are issues with vs code intellisense, so it may be a good idea to remove the extension from the marketplace or deprecate it.

@romainmenke
Copy link
Member

so it may be a good idea to remove the extension from the marketplace or deprecate it.

I agree but beyond my control here :)
Ok if we close this here?

@Antonio-Laguna
Copy link
Member

It's also beyond my control for what is worth. Only Jon can do it

@jonathantneal
Copy link
Contributor

Who me ‘Jon’? VSCode extension? I can definitely ask about that.

@romainmenke
Copy link
Member

I also opened this issue in that repo to map out what can be ported to the builtin VSCode support for CSS : csstools/postcss-language#16

@romainmenke
Copy link
Member

Going to close this here, we can follow up in the extension's repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants