Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

photo tags interfere with most recent comments #874

Open
lodewiges opened this issue Oct 8, 2024 · 4 comments · May be fixed by #876
Open

photo tags interfere with most recent comments #874

lodewiges opened this issue Oct 8, 2024 · 4 comments · May be fixed by #876
Assignees
@wilco375

Comments

@lodewiges
Copy link
Contributor

lodewiges commented Oct 8, 2024 •
edited
Loading

It looks like adding a photo tag makes the photo go to the most recently edited photo. in the past there where only comments that did this. I don't think it is relevant to show an old picture that has new tags instead showing new comments is more interesting

Is this intended behavior?

Example:
order I first placed 3 comments from test 1 to test 3 after this I added a tag to the second photo this made it go to the first place.
Wanted behavior: the photo stays on the second place, this would mean that tags don't interfere with the order photo are shown
image

image
@wilco375
Copy link
Contributor

wilco375 commented Oct 9, 2024

I'm not sure I understand the description of this issue, can you explain the problem in more detail?
Also please note that this is a public repo, try not to include personal information like names and in this case comments someone made. You can create screenshots of the staging platform if needed.

@lodewiges
Copy link
Contributor Author

lodewiges commented Oct 9, 2024 •
edited
Loading

maybe i am wrong by adding this feature to amber-api instead of amber-ui, it depends is we need a new database field to achieve this functionality.

@wilco375
Copy link
Contributor

wilco375 commented Oct 9, 2024 •
edited
Loading

Ah I see, I was confused because as an oud-lid I cannot see photo comments, so the widget does not show up on my front page. It is likely a front-end issue (unless it also requires back-end modification to properly implement). Currently, the photos are sorted by updated_at date, which is modified both when a comment, or a tag is placed:

amber-ui/app/components/tools/recent-photos.js

Line 9 in 0a74842

return this.store.query('photo', {

We might instead want to get the latest comments, and then get the images associated with those.

@lodewiges lodewiges transferred this issue from csvalpha/amber-api Oct 9, 2024
@DrumsnChocolate
Copy link
Contributor

DrumsnChocolate commented Oct 9, 2024 •
edited
Loading

Luckily, this bug still only seems to apply to photos that actually have comments. Meaning it's not just the most recently tagged photo that shows up on top, but instead the most recently tagged photo with comments.

@wilco375 wilco375 linked a pull request Oct 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilco375 wilco375

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix recent photo comments csvalpha/amber-ui
3 participants
@wilco375 @DrumsnChocolate @lodewiges