New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addLocalFolderPromise is broken when providing absolute path on mac #532

Open

koush opened this issue Aug 13, 2024 · 2 comments

koush commented Aug 13, 2024

caused by this change. fixPath is calling path.join which will join two absolute paths.

https://github.com/cthackers/adm-zip/blame/b148463f5f9f67427df6dd19798cdce20bde3d74/adm-zip.js#L488

wimbarelds commented Sep 25, 2024

Also have this issue. Resulting zip is empty

marcelowa commented Oct 30, 2024

same here
It's also happening on linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment