Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename and possibly refactor HtmlOptions #1536

Closed
ctm opened this issue Jan 7, 2025 · 1 comment
Closed

rename and possibly refactor HtmlOptions #1536

ctm opened this issue Jan 7, 2025 · 1 comment
Assignees
Labels
chore Maintenance or other non-bug, non-feature easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon

Comments

@ctm
Copy link
Owner

ctm commented Jan 7, 2025

Rename types::HtmlOptions and possibly refactor its use.

HtmlOptions was initially part of the tournament_structure module, so it was (mostly) clear that it meant HTML options for a tournament structure. However, since I misjudged and wound up relocating it to types.rs, it now sounds more generic than it really is. StructureSheetHtmlOptions would be more precise, but I may be able to refactor it into a better place than types.

I'm running into this because the code for doing structure sheets is already fairly generic and could be extended to handle hand histories as well, but it does have some tournament-structure specifics, like HtmlOptions.

There are two different ways I can approach this. The quick fix is to add the StructureSheet prefix and implement hand histories independently of the existing tournament structure code, perhaps by trying to make the hand histories even more generic so that it can subsume the tournament structure code. The alternative would be to work directly with the existing tournament structure code (and rename it to be more generic) and then use the all-singing-all-dancing version to implement hand histories.

@ctm ctm added chore Maintenance or other non-bug, non-feature high priority Should be done fairly soon easy Trivial to do (even when tired!) and semi-worthwhile labels Jan 7, 2025
@ctm ctm self-assigned this Jan 7, 2025
@ctm
Copy link
Owner Author

ctm commented Jan 7, 2025

I've decided to do the rename as part of this ticket, but to explore the refactoring directly under (#576), since that already has some stub code that I'll want to take into consideration. So, I've done the rename and it's in master, but not deployed.

@ctm ctm closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance or other non-bug, non-feature easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon
Projects
None yet
Development

No branches or pull requests

1 participant