rename and possibly refactor HtmlOptions #1536
Labels
chore
Maintenance or other non-bug, non-feature
easy
Trivial to do (even when tired!) and semi-worthwhile
high priority
Should be done fairly soon
Rename
types::HtmlOptions
and possibly refactor its use.HtmlOptions
was initially part of thetournament_structure
module, so it was (mostly) clear that it meant HTML options for a tournament structure. However, since I misjudged and wound up relocating it totypes.rs
, it now sounds more generic than it really is.StructureSheetHtmlOptions
would be more precise, but I may be able to refactor it into a better place thantypes
.I'm running into this because the code for doing structure sheets is already fairly generic and could be extended to handle hand histories as well, but it does have some tournament-structure specifics, like
HtmlOptions
.There are two different ways I can approach this. The quick fix is to add the
StructureSheet
prefix and implement hand histories independently of the existing tournament structure code, perhaps by trying to make the hand histories even more generic so that it can subsume the tournament structure code. The alternative would be to work directly with the existing tournament structure code (and rename it to be more generic) and then use the all-singing-all-dancing version to implement hand histories.The text was updated successfully, but these errors were encountered: