Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueException doesn't exist in Python #8

Open
ikajic opened this issue May 31, 2016 · 1 comment
Open

ValueException doesn't exist in Python #8

ikajic opened this issue May 31, 2016 · 1 comment
Labels
bug

Comments

@ikajic
Copy link
Collaborator

ikajic commented May 31, 2016 •
edited
Loading

In benchmark.py a ValueException is raised when 0 parameters are specified and when the same parameter is added twice to the list of defaults.

ValueException isn't a valid Python exception, so if any of the two cases above happen it ends up with:
NameError: global name 'ValueException' is not defined

Maybe ValueError, KeyError or TypeError would be more appropriate? I can submit a PR for this (if you let me :)
@ikajic ikajic added the bug label May 31, 2016
@tcstewar
Copy link
Member

Oops, damnit, that is why I should have tests. thanks for finding this!

@jgosmann jgosmann mentioned this issue May 31, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tcstewar @ikajic