Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View permissions into core ? #14

Open
olivierdalang opened this issue Mar 5, 2017 · 5 comments
Open

View permissions into core ? #14

olivierdalang opened this issue Mar 5, 2017 · 5 comments

Comments

@olivierdalang
Copy link

Hi !

There's an ongoing PR to include view permissions into django core : django/django#6734

I just found out about your work here, and since it really aims to do the same thing, I thought you may be interested ?

Bests,

Olivier

@PetrDlouhy
Copy link
Contributor

PetrDlouhy commented Apr 27, 2017

Very, very nice, I really like this project, because it frees my hands from using patched Django version, which I did for a really long time.

Is the code of this based on my initial commits, or is it stand alone work?

@lefterisnik
Copy link
Contributor

lefterisnik commented Apr 27, 2017

Hi @PetrDlouhy,

It's a stand alone work. I saw your commit and I've noticed your commit (django/django@184f416) and from what I saw, the two implementations share common features 👍

@melaku-z
Copy link

melaku-z commented Aug 8, 2018

The feature is integrated into core starting on django 2.1.

@PetrDlouhy
Copy link
Contributor

The readme should be changed accordingly to this change. It should inform, that this is useful only for compatibility in older projects and it should contain migration instructions.

@xeor
Copy link

xeor commented Sep 3, 2018

My tests just started to fail with some duplicate key value violates unique constraint "auth_permission_content..... Removing admin_view_permission from settings.py solved it.

There should be some writings about the django 2.1 release about this in this readme. I think commenting out the app like I did is the only thing you need to do when upgrading to 2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants