Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: combine APR into one item #154

Merged
merged 4 commits into from
Apr 23, 2024
Merged

task: combine APR into one item #154

merged 4 commits into from
Apr 23, 2024

Conversation

amytsang
Copy link
Contributor

@amytsang amytsang commented Apr 23, 2024 •
edited
Loading

Screenshot 2024-04-23 at 8 49 32 AM Screenshot 2024-04-23 at 7 07 11 AM
  • Remove Lend APY and Rewards APR column. Combine them into Total APR column, add Tooltip to show breakdown.
  • Reduce Supply market list size.
Screenshot 2024-04-23 at 7 07 55 AM
  • Update Rewards tAPR section to Total APR
Screenshot 2024-04-23 at 7 12 05 AM
  • Update text Fee to AMM swap fee
Screenshot 2024-04-23 at 7 13 27 AM Screenshot 2024-04-23 at 7 13 33 AM

-Update mobile view with Total APR

Screenshot 2024-04-23 at 7 14 25 AM
  • Update Lend APY to Lend APR
  • Fixed User supply list filter not showing properly.
  • Add search params routes for market list when navigating between networks.

@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
curve-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 4:16pm
curve-dapp-crvusd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 4:16pm
curve-dapp-dao ❌ Failed (Inspect) Apr 23, 2024 4:16pm
curve-dapp-lend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 4:16pm

@amytsang amytsang merged commit 6dfe6d9 into main Apr 23, 2024
4 of 5 checks passed
@amytsang amytsang deleted the task/combine-apr-into-one branch April 23, 2024 17:00
@amytsang amytsang linked an issue Apr 23, 2024 that may be closed by this pull request
Combine all APYs into a single value #142
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielSchiavini DanielSchiavini DanielSchiavini left review comments

@Macket Macket Macket approved these changes

@bout3fiddy bout3fiddy bout3fiddy approved these changes

@michwill michwill michwill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine all APYs into a single value
5 participants
@amytsang @michwill @DanielSchiavini @bout3fiddy @Macket