Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the implementation of the formula for calculating D #5

Open
exp-euler opened this issue Aug 31, 2020 · 0 comments
Open

On the implementation of the formula for calculating D #5

exp-euler opened this issue Aug 31, 2020 · 0 comments

Comments

@exp-euler
Copy link

Hi,

I'm not entirely sure, but I think there might be an issue with how Ann is defined in line 66:

Ann: uint256 = amp * n_coins_256

Shouldn't it be: Ann = amp * (n_coins_256 ^ n_coins_256) ?

I was also wondering if there is any particular reason for not implementing a more sophisticated numerical method? Also, on the tolerance for D, wouldn't it be better if we got a more precise D?

Thanks,
Thoma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant