Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve config handler, large restructuring and start of testing and type annotations #11

Merged
merged 21 commits into from
May 13, 2020
Merged

Improve config handler, large restructuring and start of testing and type annotations #11

merged 21 commits into from
May 13, 2020

Conversation

cwerner
Copy link
Owner

@cwerner cwerner commented May 12, 2020 •
edited
Loading

This is a large PR since it touches on many aspects of the program.

Changes:

  • break messy config handling and introduce config_handler class
  • new variable class that encapsulates name, unit and source col handling
  • due to the complexity of the change pytest testing is introduced as well (about time)
  • for most new code type hints are introduced (more to come)

NOTE: Currently, some tests for the ConfigParser class had to be disabled on GitHub Actions CI workflow. They do pass on localhost. Not sure what the reason is - most likely differences of the local file system contents (also maybe pyfakefs)...
I'll track this with issue #12.

This closes #7, closes #8, and closes #10

cwerner added 21 commits May 2, 2020 22:40
@cwerner
move tests into ldndc2nc folder
89a298c
@cwerner
parse_config requires a section arg
035c442
@cwerner
add test for find_config and new dev requirement pyfakefs for fs mocking
252aeaa
@cwerner
update default conf to new multi-var syntax
976645a
@cwerner
update gitignore
4cd5c08
@cwerner
remove superfluous update_docs.sh
2704c37
@cwerner
add some special folders/ files to gitignore
3f03fda
@cwerner
add some special folders/ files to gitignore (2)
fcbf598
@cwerner
add some special folders/ files to gitignore (3)
f2324ec
@cwerner
change tests from xfail to raises
5dbd473
@cwerner
add new config_handler and variable classes and associated tests
d7f7c69
@cwerner
move to config_handler (incomplete)
3709b81
@cwerner
make sure we do not drop cols prematurely in case of aggregate cols
4994f45
@cwerner
allow nan and 0 as non-id values in reffile
096b90e
@cwerner
new id_mapper and various changes to variable and unit handling
13c33be
@cwerner
small fix
6ce2647
@cwerner
disable test for confighandler.file_path momentarily
25e748a
@cwerner
add setuptools to gh actions ci
8e82f09
@cwerner
fix test_find_path for config_handler
89fdd61
@cwerner
small fix
8d2f7be
@cwerner
disbale config_handler test to see if this makes it pass the github a…
e939b04 
…ctions ci test step
@cwerner cwerner linked an issue May 13, 2020 that may be closed by this pull request
Some Confighandler tests fail on GitHub Actions CI #12
Open
@cwerner cwerner merged commit 25cbf48 into master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@cwerner