specextract use make_tool instead of importing global instance

[kglotfelty]

We should look at replacing the import of individual tools

ciao-contrib/ciao_contrib/_tools/specextract.py

Line 31 in 26981f4

from ciao_contrib.runtool import dmstat, dmcoords, dmlist, acis_fef_lookup, get_sky_limits, new_pfiles_environment

with using make_tool in the places where they are used.

from ciao_contrib.runtool import make_tool
dmstat = make_tool("dmstat")

This is especially important for dmstat which is storing info back into it's own parameter file and especially when running in parallel. Since this is imported into the global scope, all the paralell threads are updating the same object. If you create separate objects for each parallel thread then no race condition.

This should help remove the need for so many new_pfiles_environemnt contexts.

[DougBurke]

@nplee does #736 close this issue, or is it worth keeping open?

[nplee]

@DougBurke this closes it 👍

…

On Tue, May 16, 2023 at 8:46 AM Doug Burke ***@***.***> wrote: @nplee <https://github.com/nplee> does #736 <#736> close this issue, or is it worth keeping open? — Reply to this email directly, view it on GitHub <#730 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFQ6SBWIOZSLIOHSC4X5CLDXGNZJPANCNFSM6AAAAAAT7BAXOU> . You are receiving this because you were mentioned.Message ID: ***@***.***>