Take advantage of stack support for dmimgcalc operation parameter #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If dmimgcalc is given an opstr that's "too long" (for some ill-defined criterion of what too long actually is) we switch to using the stack support, which is new in CIAO 4.15. We could always do so, but a) let's not break things we know already work b) not using a stack here is a bit cleaner We do not change how dmimgcalc_add works, since even though it could take advantage of this, we have code that seems to work, and there may be some advantage of adding data in chunks rather than all-in-one go, primarily in the amount of memory used at the expense of header/metadata shenanighans. There are some minor code-style tweaks.
|
Related to #634 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If dmimgcalc is given an opstr that's "too long" (for some ill-defined criterion of what too long actually is) we switch to using the stack support, which is new in CIAO 4.15. We could always do so, but
a) let's not break things we know already work
b) not using a stack here is a bit cleaner
We do not change how dmimgcalc_add works, since even though it could take advantage of this, we have code that seems to work, and there may be some advantage of adding data in chunks rather than all-in-one go, primarily in the amount of memory used at the expense of header/metadata shenanighans.
There are some minor code-style tweaks.