Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want per-command methods? #4

Open
DougBurke opened this issue Dec 19, 2024 · 2 comments
Open

Do we want per-command methods? #4

DougBurke opened this issue Dec 19, 2024 · 2 comments

Comments

@DougBurke
Copy link
Member

The current approach is simple, and has the advantage to not being tied down to a particular DS9 version.

We could add methods that mimic the XPA/SAMP commands, and so could provide more knowledge on the supported values. The problem with that is what happens when new commands are added, or old ones deprecated / removed (e.g. hls and hsv support is new in ds9 8.6).

@DougBurke DougBurke changed the title Do we want pre-command methods? Do we want per-command methods? Dec 19, 2024
@DougBurke
Copy link
Member Author

Of course, as soon as I start to try using this I start to see the benefit. Perhaps a subclass or some other way to provide an optional "nicely-typed" layer?

@DougBurke
Copy link
Member Author

I will note that I've already started to do this with

  • send_array/retrieve_array
  • send_fits/retrieve_fits

but this is very specialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant