You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the definition of o' and i' are swapped. The input filter dimension should the number of possible characters (35), and `c' should be the padded SMILES sequence length.
Just want to confirm this detail. I can submit a PR if that is correct.
The text was updated successfully, but these errors were encountered:
Hi! Thanks for the implementation
I think there might be some problem when implementing the conv1d layer here:
molencoder/molencoder/models.py
Line 56 in 1d7e208
I think the definition of
o' and
i' are swapped. The input filter dimension should the number of possible characters (35), and `c' should be the padded SMILES sequence length.Just want to confirm this detail. I can submit a PR if that is correct.
The text was updated successfully, but these errors were encountered: