Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling differences between dev and published #101

Closed
cyChop opened this issue Aug 10, 2016 · 4 comments
Closed

Fix styling differences between dev and published #101

cyChop opened this issue Aug 10, 2016 · 4 comments
Assignees

Comments

@cyChop
Copy link
Owner

cyChop commented Aug 10, 2016

The local rendering seems to add margins which mess with the style conception. Understand where they come from and get rid of 'em!!

@cyChop cyChop added this to the 1.0.0 milestone Aug 10, 2016
@cyChop cyChop self-assigned this Aug 10, 2016
@cyChop
Copy link
Owner Author

cyChop commented Aug 14, 2016

Left: local; right: published.
Focus on the random/shopping cart buttons and on the strength indicator.

screenshot from 2016-08-14 12-39-44

This is the same page. Does Github apply filter to the CSS?

@cyChop
Copy link
Owner Author

cyChop commented Aug 14, 2016

Minification is not the cause. Minified locally and got the same result (http://localhost:8080/dev/dist/beverages.css and https://cychop.github.io/beverages-js/dist/beverages.css are identical).

The problem has been confirmed in all tested browsers:

  • Chromium (Ubuntu 16, Windows 10);
  • Chrome (Windows 10);
  • Firefox (Ubuntu 16).

It looks like browsers have a different rendering for local and remote sheets.

cyChop added a commit that referenced this issue Aug 14, 2016
Local rendering is still different from published
@cyChop
Copy link
Owner Author

cyChop commented Aug 14, 2016

An idea to test whether this comes from a local/remote difference in interpretation from browser: publish localhost via ngrok and access via the remote address.

@cyChop cyChop removed this from the 1.0.0 milestone Aug 14, 2016
@cyChop cyChop added bug and removed in progress labels Aug 14, 2016
@cyChop cyChop closed this as completed Jan 8, 2018
@cyChop cyChop removed the in progress label Jan 8, 2018
@cyChop
Copy link
Owner Author

cyChop commented Jan 8, 2018

It appears the latest changes for #111 solved the difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant