Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Node Field Query API #6354

Closed
CoolSpy3 opened this issue Aug 15, 2023 · 1 comment · Fixed by #6613
Closed

Improve Node Field Query API #6354

CoolSpy3 opened this issue Aug 15, 2023 · 1 comment · Fixed by #6613
Labels
feature Implementation of a major feature

Comments

@CoolSpy3
Copy link
Contributor

This issue arises from a discussion occurring on this StackExchange thread which brings up two main issues:

  1. In the current API, there is no way to query the internal fields of a "parent" proto node.

Ex.

PROTO BaseProto [
     unconnectedField internalField
]
{
...
}
PROTO SubProto [
]
{
    BaseProto {
        internalField 1
    }
}

(internalField is inaccessible from SubProto nodes)

  1. The wb_supervisor_node_get_field and wb_supervisor_node_get_proto_field methods are somewhat misleading in that the former retrieves fields defined on a proto node and the latter retrieves fields defined on the base ancestor type.

In the linked thread, @omichel suggests creating wb_supervisor_node_get_proto_parent and querying fields on that object with wb_supervisor_node_get_field.

@omichel omichel added the feature Implementation of a major feature label Aug 15, 2023
@omichel omichel added this to the R2024a milestone Aug 15, 2023
@gabryelreyes gabryelreyes removed this from the R2024a milestone Jul 30, 2024
@brettle brettle mentioned this issue Aug 2, 2024
48 tasks
@CoolSpy3 CoolSpy3 linked a pull request Aug 4, 2024 that will close this issue
19 tasks
@lukicdarkoo
Copy link
Member

I supposed this is fixed in #6613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implementation of a major feature
Development

Successfully merging a pull request may close this issue.

4 participants