Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible value overloading of comment level #862

Open
afalaleev opened this issue Aug 12, 2019 · 0 comments
Open

Possible value overloading of comment level #862

afalaleev opened this issue Aug 12, 2019 · 0 comments
Labels
Low

Comments

@afalaleev
Copy link
Contributor

Description

golos.contracts/golos.publication/golos.publication.cpp

Line 243 in 22523f1

level = 1 + parent_itr->level; 

max_comment_depth_param.max_comment_depth == 2^16 - 1
level == 2^16 - 1

Decision
Add checking of max_comment_depth_param.max_comment_depth in validate-function:

golos.contracts/golos.publication/parameters.hpp

Line 35 in 22523f1

void validate() const override {

@afalaleev afalaleev added the Low label Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afalaleev