-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial #293
Tutorial #293
Conversation
Kennellyt simple
Update to user tutorial
Tutorial changes based on comments in Cyclus PR
@abachma2 What's the status here? |
fixed pyne link
I think I have addressed all of the comments from @katyhuff and @nuclearkatie (other than maybe the S vs M for energy state in the ZAID). I know @gonuke had some comments/changes earlier, not sure if he wanted to look at this before it gets merged. I don't know if other people (like @bam241) wanted to look over this before it gets merged. I haven't made any changes to the data analysis part of the tutorial ( Overall, I think this is 95% done, with the last 5% for this PR to come from any further reviews. If no one else wants to add a review then the energy state in the ZAID needs to be resolved then this can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a first round of review. I want to get these comments to you now since I'm not sure when I'll get to the rest....
source/user/tutorial/sim_parm.rst
Outdated
</simulation> | ||
|
||
The lifetime of a |Cyclus| simulation is determined by its | ||
**duration**, the number of months |Cyclus| will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we use a fixed font format for keywords?
**duration**, the number of months |Cyclus| will | |
`duration`, the number of months |Cyclus| will |
Simple simulations can easily be expanded into more complex problems. To demonstrate this, | ||
we will now add a second reactor, ``1000We Lightwater-1``, to our | ||
simulation. This reactor will have a lifetime of 360 months (30 years), | ||
cycle time of 15 months, assembly size of 30160 kg, and power capacity 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it would be better to make this some multiple of 6 months
Just pushed the final changes, specifically most of the comments from @gonuke, and adjustment of ZAID. |
Add an accepted commodity for the repository to be Separated-Waste. | ||
|
||
Activity: Save your Input File | ||
-------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this render right? Underline may not be long enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I build the pages locally, this section title renders the same as the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may give a warning and render fine...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @abachma2 and everyone else who contributed, this has been a long time coming! Very excited to see it live and be able to send new users to follow it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sticking with this @abachma2 - Mars isn't the only one with perseverance!
Merged! Thanks everyone! |
Updating the Cyclus user tutorial - Compilation of changes from multiple people at ARFC. Also includes random fixes to the website.