Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runahead: handle no sequences within start-stop cycle interval #6638

Open
wants to merge 1 commit into
base: 8.4.x
Choose a base branch
from
Open

runahead: handle no sequences within start-stop cycle interval #6638

wants to merge 1 commit into from
+34 −2

Conversation

oliver-sanders
Copy link
Member

  • Closes Handle restart with changed sequence better #6154
  • Fix a traceback which can occur in some niche circumstances where there are no sequences left within the start cycle point -> stop cycle point window after a restart.
  • This can happen as the result of a graph change.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders
runahead: handle no sequences within start-stop cycle interval
37aa99a 
* Closes cylc#6154
* Fix a traceback which can occur in some niche circumstances where
  there are no sequences left within the
  `start cycle point` -> `stop cycle point` window after a restart.
* This can happen as the result of a graph change.
@oliver-sanders oliver-sanders added bug Something is wrong :( small labels Feb 26, 2025
@oliver-sanders oliver-sanders added this to the 8.4.x milestone Feb 26, 2025
@oliver-sanders oliver-sanders self-assigned this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie Awaiting requested review from MetRonnie

@hjoliver hjoliver Awaiting requested review from hjoliver

At least 1 approving review is required to merge this pull request.

Assignees

@oliver-sanders oliver-sanders

Labels
bug Something is wrong :( small
Projects
None yet
Milestone
8.4.x
Development

Successfully merging this pull request may close these issues.
1 participant
@oliver-sanders