Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-implement 'dm_learn_from_db()' #229

Closed
5 tasks
TSchiefer opened this issue Jan 8, 2020 · 3 comments
Closed
5 tasks

re-implement 'dm_learn_from_db()' #229

TSchiefer opened this issue Jan 8, 2020 · 3 comments
Assignees
Labels
debt Technical debt
Milestone

Comments

@TSchiefer
Copy link
Member

TSchiefer commented Jan 8, 2020

It is the only function using legacy_new_dm() (with a data_model object as 2nd arg).

@krlmlr krlmlr added the debt Technical debt label Feb 14, 2020
@krlmlr krlmlr added this to the 0.1.2 milestone Feb 14, 2020
@krlmlr
Copy link
Collaborator

krlmlr commented Apr 20, 2020

Calling tbl() is slow, we can avoid the slowness by calling tbl_sql(vars = ...) directly.

@krlmlr krlmlr modified the milestones: 0.2.0, 0.1.2 Apr 20, 2020
@krlmlr krlmlr modified the milestones: 0.1.2, 0.1.3 Apr 30, 2020
@krlmlr krlmlr self-assigned this May 1, 2020
@krlmlr krlmlr modified the milestones: 0.1.3, 0.1.4 May 24, 2020
@krlmlr krlmlr modified the milestones: 0.1.4, 0.1.5 Jun 4, 2020
@krlmlr krlmlr modified the milestones: 0.1.6, 0.1.7 Jul 28, 2020
@krlmlr krlmlr modified the milestones: 0.1.7, 0.1.8 Sep 22, 2020
@krlmlr krlmlr modified the milestones: 0.1.8, 0.1.9, 0.1.10 Nov 18, 2020
@krlmlr krlmlr modified the milestones: 0.1.10, 0.1.11 Jan 6, 2021
@krlmlr krlmlr modified the milestones: 0.1.11, 0.1.13, 0.2.0, 0.2.1 Apr 25, 2021
@krlmlr krlmlr removed this from the 0.2.1 milestone May 11, 2021
@krlmlr krlmlr added this to the 0.2.2 milestone May 11, 2021
@krlmlr krlmlr modified the milestones: 0.2.2, 0.2.4 Jun 20, 2021
@krlmlr krlmlr modified the milestones: 0.2.4, 0.2.6 Oct 9, 2021
@krlmlr krlmlr modified the milestones: 0.2.6, 0.3.2 Nov 16, 2021
@krlmlr krlmlr modified the milestones: 0.3.2, 0.2.8, 0.2.9 Apr 7, 2022
@krlmlr
Copy link
Collaborator

krlmlr commented May 30, 2022

Now in #342.

@krlmlr krlmlr closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2022
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Technical debt
Development

No branches or pull requests

2 participants